Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Address deprecation of ReflectionType::getClass()#36891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#36872
LicenseMIT
Doc PRN/A

CallingReflectionType::getClass() will trigger a deprecation warning on php 8. This PR switches togetType() if available.

@derrabus
Copy link
MemberAuthor

What should I do about the fabbot failures? They're unrelated to my changes. Submit a separate PR to fix them or ignore them?

@nicolas-grekas
Copy link
Member

They are false positives. We could rewrite the code a bit to prevent fabbot from generating these patches (using concat I guess).

In this PR or another as you wish.

@derrabusderrabusforce-pushed thebugfix/get-class-deprecation branch from32443e4 to53b1677CompareMay 21, 2020 13:05
@derrabus
Copy link
MemberAuthor

Test failures on php 5.5 have been resolved. Travis is green now.

@nicolas-grekas
Copy link
Member

Thank you@derrabus.

@nicolas-grekasnicolas-grekas merged commit410b621 intosymfony:3.4May 23, 2020
@derrabusderrabus deleted the bugfix/get-class-deprecation branchMay 23, 2020 07:40
nicolas-grekas added a commit that referenced this pull requestMay 23, 2020
…eflectionParameter::getClass() (derrabus)This PR was merged into the 4.4 branch.Discussion----------[OptionsResolver][Serializer] Remove calls to deprecated ReflectionParameter::getClass()| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#36872| License       | MIT| Doc PR        | N/AFollowing#36891, this PR removes the remaining calls to `ReflectionParameter::getClass()` from the 4.4 branch.Commits-------1575d85 Remove calls to deprecated ReflectionParameter::getClass().
This was referencedMay 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@derrabus@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp