Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Add suggestion for Amazon SQS transport and make check more readable#36890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
RocKordier wants to merge0 commits intosymfony:masterfromRocKordier:feature/improve-transport-suggestion
Closed
[Messenger] Add suggestion for Amazon SQS transport and make check more readable#36890
RocKordier wants to merge0 commits intosymfony:masterfromRocKordier:feature/improve-transport-suggestion
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesMay 22, 2020
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(for 5.1)
fcfd60e to4f93cc1Comparechalasr added a commit that referenced this pull requestMay 22, 2020
…make check more readable (RocKordier)This PR was merged into the 5.1 branch.Discussion----------[Messenger] Add suggestion for Amazon SQS transport and make check more readable| Q | A| ------------- | ---| Branch? | 5.1| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Copy-paste of#36890Commits-------de7f3fc [Messenger] Add suggestion for Amazon SQS transport and make check more readable
Member
chalasr commentedMay 22, 2020
I missed up with git while merging, sorry. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Amazon Simple Queue Service Transportintroduced in[Messenger] Add SQS transport #32454..Factory->supports(..functions also and no one has to count characters.