NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] Make ExpressionLanguageSyntax validator usable with annotation#36886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.1fromjderusse:fix-constraint

May 22, 2020

Merged

[Validator] Make ExpressionLanguageSyntax validator usable with annotation#36886

fabpot merged 1 commit intosymfony:5.1fromjderusse:fix-constraint

May 22, 2020

Conversation

Copy link

Member

jderusse commentedMay 20, 2020

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	NA
License	MIT
Doc PR	NA

When using the new on an entity ExpressionLanguageSyntax (basicaly copy/pasted the sample fromhttps://symfony.com/blog/new-in-symfony-5-1-expressionlanguage-validator), I face a first error:

Constraint validator "" does not exist or is not enabled. Check the "validatedBy" method in your constraint class "Symfony\Component\Validator\Constraints\ExpressionLanguageSyntax".

indeed, theservice isneed to generate a valide alias

Which looks weird for a Constraint

This PR makes the ExpressionLanguage dependency optionnal inExpressionLanguageSyntaxValidator, and removes theservice than is not needed anyore

carsonbot added Status: Needs Review Validator Bug labels

May 20, 2020

Copy link

MemberAuthor

jderusse commentedMay 20, 2020

ping@Andrej-in-ua

jderusse commented

May 20, 2020

View reviewed changes

src/Symfony/Component/Validator/Constraints/ExpressionLanguageSyntaxValidator.php Outdated

		}
		}

		privatefunctiongetExpressionLanguage():ExpressionLanguage

Copy link

MemberAuthor

jderusseMay 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

inspired from

symfony/src/Symfony/Component/Validator/Constraints/ExpressionValidator.php

Lines 53 to 60 in93248c9

	privatefunctiongetExpressionLanguage():ExpressionLanguage
	{
	if (null ===$this->expressionLanguage) {
	$this->expressionLanguage =newExpressionLanguage();
	}

	return$this->expressionLanguage;
	}