Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] validate subforms in all validation groups#36865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromxabbuh:issue-36852
May 30, 2020

Conversation

@xabbuh
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36852
LicenseMIT
Doc PR

// in different steps without breaking early enough
$this->resolvedGroups[$field] = (array)$group;
$validator->atPath(sprintf($fieldPropertyPath,$field->getPropertyPath()))->validate($field,$formConstraint);
$fieldFormConstraint =newForm();
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is needed for now to prevent hash collisions (see also#36415).

fancyweb reacted with thumbs up emoji
/* @var $metadata ClassMetadata */
$metadata->addConstraint(newForm());
$metadata->addPropertyConstraint('children',newValid());
$metadata->traversalStrategy = TraversalStrategy::NONE;
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

traversal happens explicitly inside theFormValidator

@xabbuhxabbuhforce-pushed theissue-36852 branch 3 times, most recently fromd17a4d2 to2fa63a5CompareMay 21, 2020 11:40
@xabbuhxabbuh marked this pull request as ready for reviewMay 21, 2020 11:56
@xabbuh
Copy link
MemberAuthor

This is ready to be reviewed.

@xabbuhxabbuhforce-pushed theissue-36852 branch 3 times, most recently from68fcedb to27d9f82CompareMay 21, 2020 11:59
@xabbuh
Copy link
MemberAuthor

/cc@HeahDude

@lyrixx
Copy link
Member

Hello,

I ran our full test suite and I confirm this patch fixed everything. It's all 💚

Thanks@xabbuh and@stof

xabbuh reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit2e8ae40 intosymfony:3.4May 30, 2020
This was referencedMay 31, 2020
@fabpotfabpot mentioned this pull requestMay 31, 2020
@xabbuhxabbuh deleted the issue-36852 branchMay 31, 2020 06:28
@bendavies
Copy link
Contributor

This breaks property mapping in some way.
Investigating.

@xabbuh
Copy link
MemberAuthor

Maybe the same as#37027?

@bendavies
Copy link
Contributor

@xabbuh yes looks like it. also#37025

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@xabbuh@lyrixx@nicolas-grekas@bendavies@stof@TvitiDev@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp