Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Bring back the debug toolbar#36838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromderrabus:bugfix/debug-toolbar
May 18, 2020

Conversation

@derrabus
Copy link
Member

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36836
LicenseMIT
Doc PRN/A

This PR effectively reverts#36789 in order to fix a regression caused by that PR.

@derrabusderrabus changed the title[HttpKernel] Revert "Change priority of KernelEvents::RESPONSE subscriber"[HttpKernel] Bring back the debug toolbarMay 16, 2020
@chalasrchalasr added this to the4.4 milestoneMay 16, 2020
@noniagriconomie
Copy link
Contributor

Can it be usefull to create a simple test where the priority of events are set and garanty that the order does not change when runing the test?
Because changing the priority should be something to do very carefuly imo, moreover core events

@derrabus
Copy link
MemberAuthor

derrabus commentedMay 17, 2020•
edited
Loading

This PR reverts the priorities to the state of 4.4.8, which should be a safe change.

Apart from that, yes: Some kind of integration test that prevents future regressions would make sense here.

noniagriconomie reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@derrabus.

@fabpotfabpot merged commit87c6683 intosymfony:4.4May 18, 2020
@derrabusderrabus deleted the bugfix/debug-toolbar branchMay 18, 2020 08:51
This was referencedMay 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@derrabus@noniagriconomie@fabpot@javiereguiluz@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp