Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Improved upgrade path for custom remember me services#36832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedMay 16, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?-
Deprecations?-
Tickets#36806 (comment)
LicenseMIT
Doc PR

This improves the upgrade path for custom remember me services nowLogoutHandlerInterface has been deprecated.

As suggested in#36806 (comment), thelogout() method should be added to theRememberMeServicesInterface in Symfony 6.

This patch allows developers to write a custom class implementing onlyRememberMeServicesInterface with alogout() method. Requiring them to implementLogoutHandlerInterface will mean they have to maintain 2 version of the class to support both Symfony 5.1+ and 6.0.

@wouterjwouterjforce-pushed thepr-36806/add-deprecation branch from2035b08 toc49d00fCompareMay 16, 2020 11:05
@nicolas-grekasnicolas-grekas added this to the5.1 milestoneMay 16, 2020
@nicolas-grekas
Copy link
Member

Thank you@wouterj.

@nicolas-grekasnicolas-grekas merged commitc268915 intosymfony:masterMay 16, 2020
@nicolas-grekas
Copy link
Member

I'll let you deal with the doc side of this PR, if there is any.

wouterj reacted with thumbs up emoji

@wouterjwouterj deleted the pr-36806/add-deprecation branchMay 16, 2020 12:07
@wouterj
Copy link
MemberAuthor

wouterj commentedMay 16, 2020•
edited
Loading

Thanks for the quick merge!

For future reference: I don't think docs need to be updated. Implementing a custom remember me service is very unlikely (given that the two implementations of Symfony already have a token provider abstraction layer).

@fabpotfabpot mentioned this pull requestMay 16, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@wouterj@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp