Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] fix PHP warning + accept status code >= 600#36823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
0b2645d to86634a5CompareUh oh!
There was an error while loading.Please reload this page.
86634a5 toc764b5cComparejaviereguiluz approved these changesMay 15, 2020
Merged
Contributor
gmponos commentedMay 17, 2020
Does this allow also status codes like |
MemberAuthor
nicolas-grekas commentedMay 17, 2020
Nope it doesn't. Those will trigger a TransportExceptionInterface |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the PHP warning reported in the linked issue.
This also relaxes the accepted status codes, withhttps://www.linkedin.com/company/linkedin/ as an example that returns a non-conformant one (
999).These are now handled as 5xx codes, ie they trigger a ServerException.