Instead of adding many ways to add more colors than the current "default" ones, I've opted to only add true color support via Hex CSS colors. If you have something else (RGB, HSV, ...), you need to first convert it to a CSS color. I've also decided to not support the ANSI 256 colors as most terminals support true colors nowadays.

If true colors are not supported by the terminal, we fall back to the "nearest" default color.

<fg=green;bg=blue> is now equivalent to<fg=#00ff00;bg=#00f>.

TheColor class is usable outside of the Console framework as well:

$color =newColor('black','white');echo$color->apply("foo");echo"\n";$color =newColor('red','yellow');echo$color->apply("foo");echo"\n";$color =newColor('#000000','#ffffff');echo$color->apply("foo");$color =newColor('#000','#fff', ['underscore','reverse']);echo$color->apply("bar");echo"\n";

Rainbow time!

functionrainbowColor($i) {$h = (int) ($i /43);$f = (int) ($i -43 *$h);$t = (int) ($f *255 /43);$q =255 -$t;if ($h ==0) {returnnewColor('',sprintf('#FF%02x00',$t));    }elseif ($h ==1) {returnnewColor('',sprintf('#%02xFF00',$q));    }elseif ($h ==2) {returnnewColor('',sprintf('#00FF%02x',$t));    }elseif ($h ==3) {returnnewColor('',sprintf('#00%02xFF',$q));    }elseif ($h ==4) {returnnewColor('',sprintf('#%02x00FF',$t));    }elseif ($h ==5) {returnnewColor('',sprintf('#FF00%02x',$q));    }}for ($i =0;$i <128;$i++) {echorainbowColor($i)->apply('');}echo"\n";for ($i =255;$i >=128;$i--) {echorainbowColor($i)->apply('');}echo"\n";

carsonbot added Status: Needs Review Console Feature labels

May 13, 2020

fabpot mentioned this pull request

May 13, 2020

[WIP] [Console] Support "named", "ansi", "hex", and "rgb" color support to console formatter#26576

Closed

fabpot force-pushed theconsole-true-color branch 5 times, most recently from77b804f tob5be5dbCompare

May 13, 2020 09:52

javiereguiluz reviewed

May 13, 2020

View reviewed changes

src/Symfony/Component/Console/Color.phpShow resolvedHide resolved

fabpot force-pushed theconsole-true-color branch 2 times, most recently from8ff5fb5 toc8b9489Compare

May 13, 2020 10:27

nicolas-grekas added this to thenext milestone

May 13, 2020

kevin-verschaeve reviewed

May 14, 2020

View reviewed changes

src/Symfony/Component/Console/Color.php Outdated

		}

		if (!isset(static::$colors[$color])) {
		thrownewInvalidArgumentException(sprintf('Invalid "%s" color; expected one of (%s).',$color,implode(',',array_keys(static::$colors))));

Copy link

Contributor

kevin-verschaeveMay 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe we can point out here that the user should use one of the predefined colors or an hexadecimal one ?

Copy link

Member

stof commentedMay 14, 2020

If you have something else (RGB, HSV, ...), you need to first convert it to a CSS color.

I guess you need to reword your description, to talk about hex colors. CSS colorsdo support RGB and HSL (and more to come)

stof requested changes

May 14, 2020

View reviewed changes

src/Symfony/Component/Console/Color.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Console/Tests/Formatter/OutputFormatterTest.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

May 14, 2020

fabpot force-pushed theconsole-true-color branch fromc8b9489 tofa9f895Compare

May 16, 2020 08:48

Copy link

MemberAuthor

fabpot commentedMay 16, 2020

Anyone willing to test on Windows?

Taluu reviewed

May 16, 2020

View reviewed changes

src/Symfony/Component/Console/Color.php Outdated

		*/
		finalclass Color
		{
		privatestatic$colors = [

Copy link

Contributor

TaluuMay 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

shoudn't these be consts instead ? (Same for$availableOptions)

Copy link

Member

wouterj commentedMay 16, 2020

Some tests with theColor class + the rainbow script on some windows command lines (I couldn't test the whole repository, as I haven't set-up my windows PC for development at all). As expected, no true color support, but seems like default colors work as expected.

Windows Powershell