Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Add abstract_arg() and param()#36775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fabpot
Copy link
Member

@fabpotfabpot commentedMay 10, 2020
edited
Loading

QA
Branch?maste
Bug fix?no
New feature?yes
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PR-

Added abstract_arg() and param() to configuration abstract arguments in PHP DSL.

@nicolas-grekas
Copy link
Member

What do you think about adding this also?

functionenv(string$name):string{return'%env('.$name.')%';}

@wouterj
Copy link
Member

What do you think about adding this also?

I like the idea, but I think env vars might need a special configurator to get rid of the "complex" strings likeint:key:timeout:query_string:MONGODB_URL andjson:file:resolve:AUTH_FILE?

@nicolas-grekas
Copy link
Member

I think env vars might need a special configurator to get rid of the "complex" strings

Honestly, teaching ppl with the real syntax is going to empower them much more than using some extremely specific DSL here.

ro0NL reacted with thumbs up emojiwouterj reacted with confused emoji

@fabpotfabpotforce-pushed theContainerConfigurator_abstract_arg branch from1871889 to08ff298CompareMay 16, 2020 08:50
@fabpotfabpot changed the title[DependencyInjection] Add abstract_arg[DependencyInjection] Add abstract_arg() and param()May 16, 2020
@fabpotfabpotforce-pushed theContainerConfigurator_abstract_arg branch from08ff298 to1fd4e8bCompareJune 10, 2020 02:11
@fabpotfabpot merged commit4984ce1 intosymfony:masterJun 10, 2020
@fabpotfabpot deleted the ContainerConfigurator_abstract_arg branchJune 10, 2020 02:12
fabpot added a commit that referenced this pull requestJun 10, 2020
…onfiguration in core (fabpot)This PR was merged into the 5.2-dev branch.Discussion----------Use PHP instead of XML as the prefered service/route configuration in core| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes-ish <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | n/a <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | n/aIn Symfony 6, I (we?) would want to promote usage of configuration written in PHP instead of YAML. For third-party bundles and core, we should do the same, replacing XML with PHP. Doing so would remove the need for the XML lib for core.The biggest advantage is auto-completion with any modern IDE without explicit support for Symfony, and probably one less thing to learn (how to configure things in YAML/XML).Be warned that it does NOT concern semantic configuration which is much harder.This PR does the work for the Twig bundle as an example. Once we agreed on the CS, the same should then be done for other core bundles both for service configuration and route configuration.Embeds#36775 until it is merged.Commits-------0aedd54 [Twig] Move configuration to PHP
@stof
Copy link
Member

this misses the update of the changelog of the component

@fabpot
Copy link
MemberAuthor

@stof CHANGELOG updated in8df6380

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@plozmunplozmunplozmun left review comments

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

8 participants

@fabpot@nicolas-grekas@wouterj@stof@Tobion@plozmun@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp