Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpClient] add TimeoutExceptionInterface#36766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ab5e322 to366540fCompare| "php":"^7.2.5", | ||
| "psr/log":"^1.0", | ||
| "symfony/http-client-contracts":"^1.1.8|^2", | ||
| "symfony/http-client-contracts":"^2.1.1", |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
tag to be added on symfony/contracts and symfony/http-client-contracts after merge
javiereguiluz approved these changesMay 9, 2020
e7a45e8 toab236d6CompareUh oh!
There was an error while loading.Please reload this page.
d80448b toe89a845Comparefabpot approved these changesMay 10, 2020
Member
fabpot commentedMay 10, 2020
Thank you@nicolas-grekas. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is fixing a design issue: unlike any other
TransportExceptionInterface, timeouts are not fatal transport errors. For this reason, we must allow one to identify them.This PR also marks exception classes asthis would revert#30549@internal, to encourage ppl to catch them using their interface and not their class name.