Then there is going to be zero different between calling reject() and calling ack(). This looks suspicious to me.

Maybe that introducing a newdelete_after_reject option would make more sense. As a reminder, this option is here to cover memory usage (7c416a7) although#36619 is an issue where rejected (not acknowledged) messages would not be available to other consumers. Acknowledged messages would could still be deleted to spare memory even though rejected ones could persist.

Then there is going to be zero different between calling reject() and calling ack(). This looks suspicious to me.

Whoops, missed the comment.

Pretty much yes, rejection and acknowledgement becomes undistinguishable. From my point of view, acknowledgement means "Yup, I've seen this message and I've handled it". Whether it was rejected or handled ok is not possible to pass to Redis as there is noXREJect command anyway.

This is similar to how Kafka handles messages, which is what Redis streams are based on conceptually. It is simply a structured log that you go through, acknowledging messages as they come (meaning, "I've read it").

https://redis.io/topics/streams-intro

Consumer groups were initially introduced by the popular messaging system called Kafka (TM). Redis reimplements a similar idea in completely different terms, but the goal is the same: to allow a group of clients to cooperate consuming a different portion of the same stream of messages.

As you can see in the original,XACK was sent to Redis just beforeXDEL anyway. Deleting the message causes other consumer groups to be unable to handle that message, despite potentially being able to.
In my case, other consumer group is simply another application. Errors during deserialization caused Worker to reject the message and delete, even though another app was perfectly able to work with it.

As a reminder, this option is here to cover memory usage

(delete_after_ack) I would like to add some sort of warning/note to documentation of this feature (probably in another PR?). I can see where it comes from, but it's "only" reasonable to delete messages if only one consumer group is assumed (that is, Messenger component is treated as internal application queue, not as a method of different application parts / applications to speak to one another).
In cases where another consumer group shows up, it breaks consumer group functionality in Redis.

@sroze could you give your opinion on this if you have some spare time? I'd like to adjust the PR to match.

Does this need some tests to be added, or will it be good as-is, even with new configuration propertydelete_after_reject?

EDIT: Also, whatdelete_after_reject default value should be? From my point of view it should maybe follow thedelete_after_ack property if it is set, and befalse otherwise?
I think that this would prevent messages from being deleted (which is what surprised me in the original issue) while keeping the intent of managing redis's memory indelete_after_ack =true case.

EDIT2: I rebased the PR to the currentmaster5.1 branch. And I've put a lot of people on reviever list by doing so... Sorry 😞 😢

Looks good to me, but I'm not sure this qualifies as a bugfix given it introduces a new option (and thus requires code changes).

I agree with@chalasr, this should target 5.2 (aka master).

@fabpot@chalasr I'll rebase and adjust the PR accordingly.

Hopefully I won't pull half of the community into it this time 🙈

Thank you@Steveb-p.