Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Fix messenger:failed:remove can not remove single message#36660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromtienvx:messenger-fix-remove-single-failed-message
May 3, 2020
Merged

[Messenger] Fix messenger:failed:remove can not remove single message#36660

fabpot merged 1 commit intosymfony:masterfromtienvx:messenger-fix-remove-single-failed-message
May 3, 2020

Conversation

tienvx
Copy link
Contributor

QA
Branch?master
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36659
LicenseMIT
Doc PR-

Fix this error:

count(): Parameter must be an array or an object that implements Countable

When callingmessenger:failed:remove command from other code with single id

@tienvx
Copy link
ContributorAuthor

Related to#34980

@fabpot
Copy link
Member

I agree with@xabbuh that the fix is not correct. Theid argument is declared as being an array, so an array must be passed. We could fix the validation of the arguments passed to the command when using an ArrayInput instead, that would be better.

@xabbuh
Copy link
Member

I think I understand the issue now. We changed the type of the argument for 5.1. So the PR that introduced the possibility to specify more than one id broke BC.

@chalasrchalasr added this to thenext milestoneMay 2, 2020
Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this PR is correct.

PR#34980 introduced a BC break to change the type from int to array. It was fine as long as you called the command from the CLI.

This PR is needed to avoid us releasing this BC break.

@fabpot
Copy link
Member

Thank you@tienvx.

@fabpotfabpot merged commit87a5701 intosymfony:masterMay 3, 2020
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@tienvxtienvx deleted the messenger-fix-remove-single-failed-message branchMay 4, 2020 15:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@NyholmNyholmNyholm approved these changes

@xabbuhxabbuhxabbuh approved these changes

@srozesrozeAwaiting requested review from sroze

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Messenger] messenger:failed:remove can not remove single message
7 participants
@tienvx@fabpot@xabbuh@Nyholm@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp