Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support of PHP8 static return type for withers#36636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@l-vo
Copy link
Contributor

@l-vol-vo commentedApr 30, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Ticketshttps://github.com/orgs/symfony/projects/1#card-35852557
LicenseMIT
Doc PRsymfony/symfony-docs#13619

@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 30, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, I just realized the check should also verify that@return $this is NOT present.
We really miss the$this return type, which would provide much better clarity and would save us many annotations.
With the current state, we'll still have to use docblocks to help differentiate those two situations.

/cc@nikic FYI, in case this can be considered for PHP v8

@l-vol-voforce-pushed thedetect_php8_static_returntype_for_withers branch 5 times, most recently fromab722c1 tod586092CompareApril 30, 2020 14:15
@l-vo
Copy link
ContributorAuthor

Updated 🙂

@l-vol-voforce-pushed thedetect_php8_static_returntype_for_withers branch fromd586092 to345a294CompareApril 30, 2020 14:55
@l-vo
Copy link
ContributorAuthor

I still have a problem on travis 7.2/php_extra=7.4, my check on PHP_VERSION_ID seems not working on this environment 🤔 Do I miss something specific to this environment ?

@nicolas-grekas
Copy link
Member

You need to list the new file in.github/patch-types.php

@l-vol-voforce-pushed thedetect_php8_static_returntype_for_withers branch 2 times, most recently from28cd280 to6cea5daCompareApril 30, 2020 20:04
@l-vol-voforce-pushed thedetect_php8_static_returntype_for_withers branch from6cea5da to04fdf05CompareApril 30, 2020 20:10
@l-vo
Copy link
ContributorAuthor

Updated 🙂

@fabpot
Copy link
Member

Thank you@l-vo.

@fabpotfabpot merged commiteebb3ef intosymfony:masterMay 3, 2020
@l-vol-vo deleted the detect_php8_static_returntype_for_withers branchMay 3, 2020 19:42
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

4 participants

@l-vo@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp