Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] fix lazy property usage.#36627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Component/Validator/Tests/Validator/AbstractValidatorTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas approved these changesMay 1, 2020
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(with one minor comment)
nicolas-grekas approved these changesMay 1, 2020
xabbuh approved these changesMay 2, 2020
Member
xabbuh commentedMay 2, 2020
Thank you@bendavies. |
This was referencedMay 31, 2020
Merged
Merged
Merged
Contributor
guilliamxavier commentedJun 5, 2020
FTR: Refs#36245 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This attempts to fix a large regression introduced in#36343, which broke recursing values returned from
getterConstraints, because they are now wrapped in in aLazyProperty. TheLazyPropertyneeds to be evaluated because some checks are done on the type of$value, i.eis_arrayetc... invalidateGenericNode.I'm concerned that the original PR didn't really add sufficient test coverage for the introduction of
LazyProperty, and I'm not 100% sure that I've caught all the cases where theinstanceofcheck are needed in this PR.For the tests, I added the
@dataProvider getConstraintMethodsto every test that hit the problem area of code.The only issue is that my fixed has broken the test introduced in#36343,testGroupedMethodConstraintValidateInSequence.I think I need@HeahDude to help me work through this. Maybe there is a more simple solution, one that doesn't require doinginstanceof LazyProperychecks in multiple places, because this feels very brittle.EDIT: fixed that test.