Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add cache.adapter.redis_tag_aware to use RedisCacheAwareAdapter#36596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfroml-vo:wire_redisTagAwareAdapter
Aug 13, 2020

Conversation

@l-vo
Copy link
Contributor

@l-vol-vo commentedApr 27, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Ticketshttps://github.com/orgs/symfony/projects/1#card-33761315
LicenseMIT
Doc PRsymfony/symfony-docs#14078

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedApr 30, 2020•
edited
Loading

Challenge: figure out how to make this work when using a DSN :)

@l-vo
Copy link
ContributorAuthor

@nicolas-grekas what do you mean please ? When not using the default provider ? e.g.:

mypool:tags:trueadapter:cache.adapter.redisprovider:redis://myserver:6379

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(nevermind my previous comment, here is a new try)

@l-vo
Copy link
ContributorAuthor

Status: needs work

@l-vol-vo changed the titleUse RedisTagAwareAdapter when tags is true and adapter is RedisAdd cache.adapter.redis_tag_aware to use RedisCacheAwareAdapterMay 4, 2020
@l-vol-voforce-pushed thewire_redisTagAwareAdapter branch 3 times, most recently fromf5a7c15 to79e949bCompareMay 4, 2020 13:32
@l-vo
Copy link
ContributorAuthor

l-vo commentedMay 4, 2020

Status: needs review

Copy link
Contributor

@maxheliasmaxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can you rebase, please ?

@l-vol-voforce-pushed thewire_redisTagAwareAdapter branch 3 times, most recently froma7a4fb0 to8218bb8CompareJune 16, 2020 09:50
@l-vo
Copy link
ContributorAuthor

can you rebase, please ?

Done 🙂

@maxhelias
Copy link
Contributor

I haven't tried it yet but I like it 😃

l-vo reacted with heart emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, thanks. Just minor comments and good to go on my side.

@l-vol-voforce-pushed thewire_redisTagAwareAdapter branch 2 times, most recently fromb59b6c4 to15f8148CompareJune 30, 2020 13:29
@l-vo
Copy link
ContributorAuthor

All threads resolved :)

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you fix the CHANGELOG and rebase on current master? Thank you.

@l-vol-voforce-pushed thewire_redisTagAwareAdapter branch 6 times, most recently fromc9138ea to861210dCompareAugust 13, 2020 08:08
@l-vol-voforce-pushed thewire_redisTagAwareAdapter branch from861210d to68d1638CompareAugust 13, 2020 08:31
@fabpot
Copy link
Member

Thank you@l-vo.

@fabpotfabpot merged commitf99f774 intosymfony:masterAug 13, 2020
@l-vol-vo deleted the wire_redisTagAwareAdapter branchAugust 13, 2020 09:11
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestAug 26, 2020
This PR was merged into the master branch.Discussion----------RedisTagAwareAdapter integrationDocumentation aboutsymfony/symfony#36596This PR contains documentation on `RedisTagAwareAdapter` (introduced in 4.3) **and** its integration in the fullstack framework (introduced in 5.2).I created another PR (#14081) with only the documentation about `RedisTagAwareAdapter` that targets 4.4.Close#14065Commits-------883dc98 RedisTagAwareAdapter integration
@nicolas-grekasnicolas-grekas modified the milestones:next,5.2Oct 5, 2020
@fabpotfabpot mentioned this pull requestOct 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@maxheliasmaxheliasmaxhelias left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@l-vo@nicolas-grekas@maxhelias@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp