Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Use COMPOSER_BINARY env var if available#36566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
fancyweb commentedApr 24, 2020
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | #36401 |
| License | MIT |
| Doc PR | - |
nicolas-grekas approved these changesApr 24, 2020
xabbuh approved these changesApr 25, 2020
fabpot approved these changesApr 25, 2020
Member
fabpot commentedApr 25, 2020
Thank you@fancyweb. |
This was referencedApr 28, 2020
Merged
Merged
Merged
nicolas-grekas added a commit that referenced this pull requestJun 22, 2021
…hen using simple-phpunit (Taluu)This PR was merged into the 4.4 branch.Discussion----------[PhpUnitBridge] fix handling the COMPOSER_BINARY env var when using simple-phpunit| Q | A| ------------- | ---| Branch? | 4.4 and next| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#41774| License | MITSince the renaming of the simple phpunit file (from the shebang to the php file) in#31364, it looks like the change made from#36566 was lost as it seems to have been merged after.So this PR is an attempt to "restore" that functionnality, as it was considered a bug fix on 3.4 at the time.poke `@nicolas`-grekasCommits-------9589b52 Reapply the change to allow to set the composer binary path
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.