Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
Revert "feature #30501 [FrameworkBundle][Routing] added Configurators to handle template and redirect controllers (HeahDude)"#36562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6f7382f toe4e8945CompareThank you@nicolas-grekas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Notes for you@HeahDude, when preparing the PR for 5.2
| @@ -83,7 +83,6 @@ | |||
| "symfony/messenger": "<4.4", | |||
| "symfony/mime": "<4.4", | |||
| "symfony/property-info": "<4.4", | |||
| "symfony/routing": "<5.1", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should not be re-reverted in the follow-up PR for 5.2
| * @param \DOMElement $nodeElement to parse that represents a Route | ||
| * @param string $filepath Full path of the XML file being processed | ||
| * @param \DOMElement $node Element to parse that represents a Route | ||
| * @param string $path Full path of the XML file being processed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should not be re-reverted in the follow-up PR for 5.2 (same for all this file: the changes put some lines back in their previous state and are fine as is, to reduce the diff between branches)
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit477ee19, reversing changes made to9bfa258.
The reverted PR is#30501. Actually, it's a partial revert: changes made to the
Routingcomponent are not reverted.The reason for this revert is that a discussion is still on-going in#35653 (which provides the same configuration extensions to yaml+xml), and we won't be able to resolve them in time for 5.1.
Better postpone for 5.2.
@HeahDude I invite you to open a PR after this one, reverting this very PR, which we'll consider again but for 5.2 if you don't mind.