Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache] skip APCu in chains when the backend is disabled#36555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#34962
LicenseMIT
Doc PR-

I think this should do it.

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I believe this is a hack. A useful hack and most likely exactly what you want. But still.

We don’t do the same thing if the Redis extension (or Redis lib) is missing.

@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedApr 24, 2020
edited
Loading

The difference is that the availability of the redis backend doesn't vary by runtime.
That's the best I can think of. There must be some runtime code that deals with the situation. Configuration only cannot do anything for us here (for redis it can.)

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas: I said Redis extension/lib not backend.

I get the argument that this is the only difference between CLI/HTTP. If the Redis extension was missing it would be missing on all runtimes.

👍

@nicolas-grekas
Copy link
MemberAuthor

I said Redis extension/lib not backend.

and I wrote "backend" to mean "extension" :D

The alternative would be to make the ApcuAdapter NOT throw any warning when it's not enabled and on the CLI. But as you explained in one of the issues, there should be some reporting when ApcuAdapter is used directly and it doesn't work at all. In a chain, we can relax this rule - that's what this PR proposes.

Thanks for approving :)

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit259f523 intosymfony:3.4Apr 24, 2020
This was referencedApr 28, 2020
@nicolas-grekasnicolas-grekas deleted the cache-skip-apcu-in-chain branchMay 4, 2020 08:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@NyholmNyholmNyholm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas@fabpot@javiereguiluz@Nyholm@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp