Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] fix compatibility with phpunit 9#36539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:3.4fromgarak:fix-phpunit-blacklist
Apr 24, 2020

Conversation

@garak
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36499
LicenseMIT
Doc PRnone

See related issue

martinssipenko and greg0ire reacted with thumbs up emoji
@garakgarakforce-pushed thefix-phpunit-blacklist branch froma8dddc5 to971e800CompareApril 23, 2020 08:05
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneApr 23, 2020
@nicolas-grekas
Copy link
Member

Looks likesrc/Symfony/Bridge/PhpUnit/bin/simple-phpunit also uses the blacklist.

@garakgarakforce-pushed thefix-phpunit-blacklist branch from88400b3 to811daabCompareApril 23, 2020 08:57
@garak
Copy link
ContributorAuthor

Added check in simple-phpunit too

@garakgarakforce-pushed thefix-phpunit-blacklist branch from67cdd07 to3ad44bfCompareApril 23, 2020 09:00
@garakgarakforce-pushed thefix-phpunit-blacklist branch fromffd0047 to0ecae1eCompareApril 23, 2020 12:29
@nicolas-grekasnicolas-grekas changed the titlefix compatibility with phpunit 9[PhpUnitBridge] fix compatibility with phpunit 9Apr 23, 2020
@garakgarakforce-pushed thefix-phpunit-blacklist branch from36213a5 to3cc9aabCompareApril 24, 2020 07:38
@garakgarakforce-pushed thefix-phpunit-blacklist branch fromaa5b23e toe27ed28CompareApril 24, 2020 07:56
@fabpot
Copy link
Member

Thank you@garak.

garak reacted with thumbs up emoji

@fabpotfabpot merged commit719bb15 intosymfony:3.4Apr 24, 2020
@garakgarak deleted the fix-phpunit-blacklist branchApril 24, 2020 08:32
fabpot added a commit that referenced this pull requestApr 25, 2020
This PR was merged into the 3.4 branch.Discussion----------[PhpUnitBridge] Improve dirname usage| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       |Fix#36499| License       | MITThis is a very small performance improvement on top of#36539Commits-------e721cfd Improve dirname usage
This was referencedApr 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+3 more reviewers

@martinssipenkomartinssipenkomartinssipenko left review comments

@localheinzlocalheinzlocalheinz left review comments

@Jean85Jean85Jean85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@garak@nicolas-grekas@fabpot@martinssipenko@localheinz@Jean85@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp