Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Allow invalidateTags calls to be traced by data collector#36536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@l-vo
Copy link
Contributor

@l-vol-vo commentedApr 22, 2020•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#34810
LicenseMIT
Doc PR

TraceableTagAwareAdapter is not used in the fullstack framework since tag aware pools don't have thecache.pool tag (it's the decorated adapter that has it). This PR aims to useTraceableTagAwareAdapter when a pool is configured withtags: true

@chalasrchalasr added this to the4.4 milestoneApr 23, 2020
@nicolas-grekasnicolas-grekas changed the titleAllow invalidateTags calls to be traced by data collector[Cache] Allow invalidateTags calls to be traced by data collectorApr 23, 2020
if ($definition->isAbstract()) {
continue;
}
$this->addToCollector($id,$container);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

don't we want to collect only the decorator when there is one?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, If we only collect the TagAwareAdapter, we lose the psr6 calls since the Adapter decorated by TagAwareAdapter calls these methods on itself.

@nicolas-grekas
Copy link
Member

Fixes#34810?

@l-vol-voforce-pushed theadd_tag_aware_adapters_to_collector branch from0ed7fb2 to28fdb3aCompareApril 24, 2020 11:56
@l-vo
Copy link
ContributorAuthor

l-vo commentedApr 24, 2020•
edited
Loading

Fixes#34810?

I haven't seen this issue, but yes, that fixes it.

@nicolas-grekas
Copy link
Member

Thank you@l-vo.

@nicolas-grekasnicolas-grekas merged commit1bc3ee7 intosymfony:4.4Apr 26, 2020
This was referencedApr 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@l-vo@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp