The Symfony Messenger component provides a SerializerInterface to encode/decode theEnvelope, this can be used to improve the Interoperability (seearticle from jolicode (french))

Sadly, the current implementation of SQS adapter json_encode the elements of theEnvelope (string body +string[] headers) and store everything in the SQS messageBody. That partially defect the interoperability: 3rd party have to also wrap (unwrap) message form json_encoded Body.

This PR leverage the AWS SQSBody andMessageAttribute properties to store message information:

# beforeSQS Message:Body:{"body": "hello world", "headers": {"foo": "bar"}}MessageAttributes:{}# afterSQS Message:Body:hello worldMessageAttributes:foor:bar

jderusse requested a review fromsroze as acode owner

April 22, 2020 12:29

carsonbot added Status: Needs Review Feature labels

Apr 22, 2020

chalasr added this to thenext milestone

Apr 22, 2020

chalasr added the Messenger label

Apr 22, 2020

chalasr approved these changes

Apr 22, 2020

View reviewed changes

Copy link

Member

chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 22, 2020

chalasr requested changes

Apr 22, 2020

View reviewed changes

Copy link

Member

chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tests are broken :)

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Apr 22, 2020

fabpot approved these changes

Apr 22, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Apr 22, 2020

Copy link

MemberAuthor

jderusse commentedApr 22, 2020

tests are broken because the FakeSqs service does not support MessageAttributes....iain/fake_sqs#59

I'm looking for an alternative testing image

jderusse force-pushed thesqs-interop branch fromb2ec396 to33bb508Compare

April 22, 2020 15:20

chalasr approved these changes

Apr 22, 2020

View reviewed changes

Copy link

Member

chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Remaining failures are unrelated

Improve SQS interoperability

00d84c1

chalasr force-pushed thesqs-interop branch from33bb508 to00d84c1Compare

April 23, 2020 09:06

Copy link

Member

chalasr commentedApr 23, 2020

Thank you@jderusse.

chalasr closed this in83b37e8

Apr 23, 2020

chalasr merged commit83b37e8 intosymfony:master

Apr 23, 2020

jderusse deleted the sqs-interop branch

April 23, 2020 09:11

nicolas-grekas modified the milestones:next,5.1

May 4, 2020

fabpot mentioned this pull request

May 5, 2020

Release v5.1.0-BETA1#36713

Merged

Copy link

Swahjak commentedJun 1, 2020

@jderusse @chalasr is it possible this introduced the following issue:

Error: "HTTP 400 returned for "https://sqs.eu-west-1.amazonaws.com/".\n\nCode:    InvalidParameterValue\nMessage: Message (user) attribute name contains invalid non-alphanumeric character '#x5C'. You can use only alphanumeric characters, hyphens (-), underscores (_), or periods (.).\nType:    Sender\nDetail:  \n

When trying to send a message that is serialized (using the Symfony serializer) to:

array:2 [  "body" => "{"id":9948}"  "headers" => array:3 [    "type" => "Topper\Bundle\Magento2Bundle\Messenger\Message\ProductUpdatedMessage"    "X-Message-Stamp-Symfony\Component\Messenger\Stamp\BusNameStamp" => "[{"busName":"event.bus"}]"    "Content-Type" => "application/json"  ]

Trying to get a proper description going before opening an issue.

jderusse mentioned this pull request

Jun 1, 2020

Fix invalid char in SQS Headers#37038

Merged

fabpot added a commit that referenced this pull request

Jun 3, 2020

bug#37038Fix invalid char in SQS Headers (jderusse)

773b4ef

This PR was squashed before being merged into the 5.1 branch.Discussion----------Fix invalid char in SQS Headers| Q             | A| ------------- | ---| Branch?       | 5.1| Bug fix?      | yes| New feature?  | no| Deprecations? | yes| Tickets       |#36525 (comment)| License       | MIT| Doc PR        | /From [Amazon documnetation](https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-message-attributes.html) header's name have constraints:- only `a-zA-Z0-9_\.-` + not start/end with a `.`- 256 charThis PR serialize ALL headers in a single SQS Attribute.Commits-------76a18b0 Fix invalid char in SQS Headers