Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Notifier] Throw an exception when the Slack DSN is not valid#36516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -59,7 +60,10 @@ public static function fromString(string $dsn): self | |||
| $path = $parsedDsn['path'] ?? null; | |||
| parse_str($parsedDsn['query'] ?? '', $query); | |||
| return new self($parsedDsn['scheme'], $parsedDsn['host'], $user, $password, $port, $query, $path); | |||
| $dsnObject = new self($parsedDsn['scheme'], $parsedDsn['host'], $user, $password, $port, $query, $path); | |||
| $dsnObject->dsn = $dsn; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems that this property can be non-initialized in case when Dsn object constructed through standard public constructor. This can lead to errors duringgetOriginalDsn call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed, can you submit a PR to fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
of course, will do
Improved errors in case of a DSN issue.