Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix session.attribute_bag service definition#36506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedApr 20, 2020
I'd suggest changing the factory method: it should be |
ContributorAuthor
fancyweb commentedApr 20, 2020
I thought about this but |
Member
nicolas-grekas commentedApr 20, 2020
It's not dynamic in the context of wiring. |
05220fa to293d4e4CompareUh oh!
There was an error while loading.Please reload this page.
293d4e4 to76072c6Comparenicolas-grekas approved these changesApr 20, 2020
xabbuh approved these changesApr 20, 2020
smithandre approved these changesApr 20, 2020
Member
nicolas-grekas commentedApr 21, 2020
Thank you@fancyweb. |
This was referencedApr 28, 2020
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like in#36063, the fact the the
getAttributeBagmethod is private was forgotten. It cannot be used as the factory method. I guess we can make it public. Should it maybe marked@internal?