Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Fix for translation:update command updating ICU messages#36505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@artemoliynyk
Copy link
Contributor

@artemoliynykartemoliynyk commentedApr 20, 2020•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36459
LicenseMIT

Iftranslation:update command executed with option--domain=messages – it  ignoremessages-intl-icu file and just create newmessages

MethodTranslationUpdateCommand::filterCatalogue() onMessageCatalogue::all() method to get all messages for domain
ButMessageCatalogue::all() method disredardintl-icu domains and simply merge all.

[Translation] added $strict parameter for MessageCatalogueInterface::all() to be able to get only defined domain messages
[FrameworkBundle] modified translation:update command to respect intl-icu domain

@nicolas-grekasnicolas-grekas modified the milestones:next,4.4Apr 21, 2020
@artemoliynykartemoliynyk marked this pull request as draftApril 22, 2020 10:06
@artemoliynykartemoliynyk marked this pull request as ready for reviewApril 22, 2020 10:38
@artemoliynyk
Copy link
ContributorAuthor

Travis build fails onSymfony\Bundle\FrameworkBundle\Tests\Functional\MailerTest::testMailerAssertions() test, but it's OK for me on local setup.
I believe this is unrelated erro to this PR

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, here are some remaining minor comments.

@nicolas-grekasnicolas-grekas changed the base branch from5.0 to4.4April 30, 2020 18:05
@nicolas-grekasnicolas-grekasforce-pushed thebug_36459-translation-update-ignore-inlt-icu branch from284ea74 to567cee5CompareApril 30, 2020 18:05
Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks !

artemoliynyk reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@artemoliynyk.

artemoliynyk reacted with thumbs up emoji

@fabpotfabpot merged commita5ae434 intosymfony:4.4May 3, 2020
This was referencedMay 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@artemoliynyk@fabpot@nicolas-grekas@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp