Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Filesystem] Handle paths on different drives#36497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedApr 20, 2020
Can you rebase+retarget the PR for branch 3.4 please? It looks like the bug is there also (and we'll merge 3.4 up to master eventually so 5.0 will get the fix too.) |
javiereguiluz approved these changesApr 20, 2020
886f47f to88f47ffCompareContributorAuthor
crishoj commentedApr 22, 2020
Rebased and retargeted to 3.4. |
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas approved these changesMay 4, 2020
ff76787 to00e727aCompareMember
nicolas-grekas commentedMay 4, 2020
Thank you@crishoj. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
makePathRelativestrips and ignores the drive letters given Windows paths on different drives, resulting in a relative path which does not resolve to the desired target.This PR makes
makePathRelativenotice paths on different drives, and return the full (absolute) target path in case instead.