NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Notifier] added telegram options#36496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromkrasilnikovs:add-telegram-options

Aug 9, 2020

Merged

[Notifier] added telegram options#36496

fabpot merged 1 commit intosymfony:masterfromkrasilnikovs:add-telegram-options

Aug 9, 2020

Conversation

Copy link

Contributor

krasilnikovs commentedApr 19, 2020

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

I have addedTelegramOptions model for sending a telegram message with options like the example I have usedSlackOptions.

Testing notes:

Create telegram bothttps://core.telegram.org/bots#creating-a-new-bot
Open telegram and join to the created chat
Send a message to telegram
for testing, I used the scripts
scripts.zip

carsonbot added Status: Needs Review Notifier Feature labels

Apr 19, 2020

krasilnikovs force-pushed theadd-telegram-options branch from690b712 to9405781Compare

April 19, 2020 18:22

nicolas-grekas added this to thenext milestone

Apr 19, 2020

Koc reviewed

Apr 23, 2020

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/ReplyKeyboardMarkup.phpShow resolvedHide resolved

krasilnikovs force-pushed theadd-telegram-options branch 2 times, most recently from2629d9a to8b80798Compare

April 24, 2020 17:02

flug reviewed

May 20, 2020

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/AbstractTelegramReplyMarkup.phpShow resolvedHide resolved

flug reviewed

May 20, 2020

View reviewed changes

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/Button/InlineKeyboardButton.php Outdated

		*
		* @see https://core.telegram.org/bots/api#inlinekeyboardbutton
		*/
		class InlineKeyboardButton extends AbstractKeyboardButton

Copy link

Contributor

flugMay 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	class InlineKeyboardButtonextends AbstractKeyboardButton
	finalclass InlineKeyboardButtonextends AbstractKeyboardButton

Copy link

ContributorAuthor

krasilnikovsAug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/Button/KeyboardButton.php Outdated

		*
		* @see https://core.telegram.org/bots/api#keyboardbutton
		*/
		class KeyboardButton extends AbstractKeyboardButton

Copy link

Contributor

flugMay 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	class KeyboardButtonextends AbstractKeyboardButton
	finalclass KeyboardButtonextends AbstractKeyboardButton

Copy link

ContributorAuthor

krasilnikovsAug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/ForceReply.php Outdated

		*
		* @see https://core.telegram.org/bots/api#forcereply
		*/
		class ForceReply extends AbstractTelegramReplyMarkup

Copy link

Contributor

flugMay 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	class ForceReplyextends AbstractTelegramReplyMarkup
	finalclass ForceReplyextends AbstractTelegramReplyMarkup

Copy link

ContributorAuthor

krasilnikovsAug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/InlineKeyboardMarkup.php Outdated

		*
		* @see https://core.telegram.org/bots/api#inlinekeyboardmarkup
		*/
		class InlineKeyboardMarkup extends AbstractTelegramReplyMarkup

Copy link

Contributor

flugMay 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	class InlineKeyboardMarkupextends AbstractTelegramReplyMarkup
	finalclass InlineKeyboardMarkupextends AbstractTelegramReplyMarkup

Copy link

ContributorAuthor

krasilnikovsAug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/Button/AbstractKeyboardButton.phpShow resolvedHide resolved

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/ReplyKeyboardRemove.php Outdated

		*
		* @see https://core.telegram.org/bots/api#replykeyboardremove
		*/
		class ReplyKeyboardRemove extends AbstractTelegramReplyMarkup

Copy link

Contributor

flugMay 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	class ReplyKeyboardRemoveextends AbstractTelegramReplyMarkup
	finalclass ReplyKeyboardRemoveextends AbstractTelegramReplyMarkup

Copy link

ContributorAuthor

krasilnikovsAug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

fabpot requested changes

Aug 6, 2020

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Anything else needs to be done before merging?

src/Symfony/Component/Notifier/Bridge/Telegram/Reply/Markup/AbstractTelegramReplyMarkup.phpShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 6, 2020

krasilnikovs force-pushed theadd-telegram-options branch from8b80798 tob4edd0dCompare

August 7, 2020 18:28

[Notifier] added telegram options

3ba8d8f

krasilnikovs force-pushed theadd-telegram-options branch fromb4edd0d to3ba8d8fCompare

August 7, 2020 19:11

fabpot approved these changes

Aug 9, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Aug 9, 2020

Copy link

Member

fabpot commentedAug 9, 2020

Thank you @krasilnikovm.

fabpot mentioned this pull request

Aug 9, 2020

[Notifier] added telegram optionssymfony/symfony-docs#14044

Closed

fabpot merged commitf4668b5 intosymfony:master

Aug 9, 2020

nicolas-grekas modified the milestones:next,5.2

Oct 5, 2020

fabpot mentioned this pull request

Oct 5, 2020

Release v5.2.0-BETA1#38417

Merged

Labels

Feature Notifier Status: Reviewed

6 participants

Movatterモバイル変換

Uh oh!

[Notifier] added telegram options#36496

[Notifier] added telegram options#36496

Uh oh!

Conversation

krasilnikovs commentedApr 19, 2020

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabpot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fabpot commentedAug 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants