NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[String] allow passing a string of custom characters to ByteString::fromRandom#36471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromazjezz:rand-string-chars

May 5, 2020

Merged

[String] allow passing a string of custom characters to ByteString::fromRandom#36471

fabpot merged 1 commit intosymfony:masterfromazjezz:rand-string-chars

May 5, 2020

Conversation

Copy link

Contributor

azjezz commentedApr 16, 2020

Q	A
Branch?	master
Bug fix?	no
New feature?	yes/
Deprecations?	no
License	MIT
Doc PR	symfony/symfony-docs#...

carsonbot added Status: Needs Review Feature labels

Apr 16, 2020

azjezz force-pushed therand-string-chars branch from632963b to184ee9cCompare

April 16, 2020 18:22

nicolas-grekas added this to thenext milestone

Apr 16, 2020

azjezz force-pushed therand-string-chars branch 3 times, most recently from669bb22 to9f8878fCompare

April 16, 2020 18:31

nicolas-grekas reviewed

Apr 16, 2020

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, here are some early random comments :)

src/Symfony/Component/String/ByteString.php OutdatedShow resolvedHide resolved

src/Symfony/Component/String/ByteString.phpShow resolvedHide resolved

src/Symfony/Component/String/ByteString.php OutdatedShow resolvedHide resolved

src/Symfony/Component/String/ByteString.phpShow resolvedHide resolved

src/Symfony/Component/String/CHANGELOG.md OutdatedShow resolvedHide resolved

src/Symfony/Component/String/Tests/ByteStringTest.phpShow resolvedHide resolved

src/Symfony/Component/String/ByteString.php

		// Worst case, it is 2^k + 1, which means we need (k+1) bits and we
		// have around a 50% chance of missing as k gets larger
		if ($index < $alphabet_size) {
		$ret .= $alphabet[$index];

Copy link

Member

nicolas-grekasApr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

funny idea: move the function on the base class and allow "characters" to be either code points and/or grapheme clusters, depending on what chunk() returns