Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] CacheItem with tag is never a hit after expired#36457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexander-schranz
Copy link
Contributor

@alexander-schranzalexander-schranz commentedApr 15, 2020•
edited
Loading

QA
Branch?4.4
Bug fix?yes/no
New feature?no
Deprecations?no
TicketsFix#36458
LicenseMIT
Doc PRsymfony/symfony-docs#...

It seems like a tag cacheItem is never a hit again. Not sure how fix this but the cache component is really hard to debug 🙈 .

It need to be somewhere generally as all TagAware caches are effected:

1) Symfony\Component\Cache\Tests\Adapter\FilesystemTagAwareAdapterTest::testRefreshAfterExpiresFailed asserting that false is true./home/travis/build/symfony/symfony/src/Symfony/Component/Cache/Tests/Traits/TagAwareTestTrait.php:1942) Symfony\Component\Cache\Tests\Adapter\PredisTagAwareClusterAdapterTest::testRefreshAfterExpiresFailed asserting that true is false./home/travis/build/symfony/symfony/src/Symfony/Component/Cache/Tests/Traits/TagAwareTestTrait.php:1833) Symfony\Component\Cache\Tests\Adapter\RedisTagAwareAdapterTest::testRefreshAfterExpiresFailed asserting that true is false./home/travis/build/symfony/symfony/src/Symfony/Component/Cache/Tests/Traits/TagAwareTestTrait.php:1834) Symfony\Component\Cache\Tests\Adapter\RedisTagAwareClusterAdapterTest::testRefreshAfterExpiresFailed asserting that true is false./home/travis/build/symfony/symfony/src/Symfony/Component/Cache/Tests/Traits/TagAwareTestTrait.php:183

andrerom reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Did you try with 3.4?

@alexander-schranz
Copy link
ContributorAuthor

alexander-schranz commentedApr 15, 2020•
edited
Loading

@nicolas-grekas the bug only appears with the classes which extend fromAbstractTagAwareAdapter like FilesystemTagAwareAdapter which do not exist in 3.4 only in 4.3 . Thenew TagAwareAdapter(new FileSystemAdapter)); which exist before does not contain this behaviour.

@alexander-schranzalexander-schranz changed the title[Cache] CacheItem with tag is never a hit after expired[Cache] [Reproducer] CacheItem with tag is never a hit after expiredApr 16, 2020
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneApr 18, 2020
@nicolas-grekasnicolas-grekas marked this pull request as ready for reviewApril 18, 2020 14:29
@nicolas-grekasnicolas-grekasforce-pushed thebugfix/filesystem-tag-aware-adapter-test branch fromf8a8eb1 tod082ecaCompareApril 18, 2020 14:29
@nicolas-grekas
Copy link
Member

I pushed the fix on your fork. Redis adapters don't have the bug. The transient failures related to them are due to expirations being time-sensitive.
FilesystemTagAwareAdapter is the one that needed a fix.

@chalasrchalasr changed the title[Cache] [Reproducer] CacheItem with tag is never a hit after expired[Cache] CacheItem with tag is never a hit after expiredApr 18, 2020
@alexander-schranz
Copy link
ContributorAuthor

@nicolas-grekas looks good. Thank you for having a look at this 👍. Travis error seems to have nothing todo with the changes in this PR.

@nicolas-grekas
Copy link
Member

Thank you@alexander-schranz.

@nicolas-grekasnicolas-grekas merged commit95becc4 intosymfony:4.4Apr 19, 2020
@alexander-schranzalexander-schranz deleted the bugfix/filesystem-tag-aware-adapter-test branchApril 20, 2020 08:29
This was referencedApr 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-schranz@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp