Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Ldap] Feature/force lowercase attributes#36432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…e all lowercase, to reduce overall confusion and enforce a standard (if desired).
OskarStark left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add a testcase
| { | ||
| private$dn; | ||
| private$attributes; | ||
| private$force_lowercase_attributes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Variables should be named in camelCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, I'll change it. I'm surprised the PSR tests didn't pick that up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
friendly ping
fabpot commentedJul 31, 2020
@elvis2 Any news? |
fabpot commentedSep 5, 2020
Closing as there is no more activity. Feel free to reopen when you have time. |
derrabus commentedNov 16, 2020
New PR:#39037 |
…(karlshea)This PR was merged into the 5.3-dev branch.Discussion----------[Ldap] Ldap Entry case-sensitive attribute key option| Q | A| ------------- | ---| Branch? | 5.x| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | N/A| License | MIT| Doc PR | N/ASee PR#36432Commits-------d3b9440 [Ldap] Ldap Entry case-sensitive attribute key option
…e all lowercase, to force case insensitivity and enforce a standard (if desired) for the consumer software.
Why? Companies have different AD setups, some force certain naming conventions, that developers may not know what and why. Coding around these pseudo standards introduces complex code that isn't necessary. Allowing the SE to force all lowercase attributes will ease their utilization of symfony/ldap and overall (I think) have better quality code.