Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Add FIFO support to the SQS transport#36431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

cv65kr
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Ticketsno
LicenseMIT
Doc PR--

https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html

tyx, shouze, and npanau reacted with heart emojishouze reacted with rocket emoji
@cv65krcv65kr requested a review fromsroze as acode ownerApril 11, 2020 22:02
@cv65krcv65krforce-pushed thefeature/messenger/sqs-support-fifo branch 2 times, most recently from3975263 to8ab8980CompareApril 11, 2020 22:05
@nicolas-grekasnicolas-grekas changed the titleFIFO support for SQS[Messenger] FIFO support for SQSApr 12, 2020
@nicolas-grekasnicolas-grekas changed the title[Messenger] FIFO support for SQS[Messenger] Add FIFO support to the SQS transportApr 12, 2020
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 12, 2020
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. ping@jderusse

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like@jderusse idea by using a stamp to configure FIFO parameters.

@cv65kr
Copy link
ContributorAuthor

@jderusse@Nyholm good point! updated.

Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just a small comment

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR.

Im happy with this after the fix suggested by@jderusse

@cv65kr
Copy link
ContributorAuthor

@jderusse@Nyholm updated, thanks for review.

@cv65krcv65krforce-pushed thefeature/messenger/sqs-support-fifo branch from27d5847 toff9a8eeCompareApril 13, 2020 12:23
Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome. Thank you!

This looks like a great first contribution.

cv65kr reacted with hooray emoji
@fabpotfabpotforce-pushed thefeature/messenger/sqs-support-fifo branch fromff9a8ee to3760175CompareApril 17, 2020 03:34
@fabpot
Copy link
Member

Thank you@cv65kr.

Nyholm reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@jderussejderussejderusse approved these changes

@NyholmNyholmNyholm approved these changes

@chalasrchalasrchalasr approved these changes

@srozesrozeAwaiting requested review from sroze

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

7 participants
@cv65kr@fabpot@nicolas-grekas@jderusse@Nyholm@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp