Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versions#36408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@soyuka
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsna
LicenseMIT
Doc PRna

expectExceptionMessageRegExp is deprecated coming phpunit 8.5.3 seesebastianbergmann/phpunit#4133

Not sure if I need to add something else lmk.

dunglas and dmaicher reacted with thumbs up emoji
@soyukasoyuka changed the base branch frommaster to4.4April 9, 2020 17:54
@soyukasoyukaforce-pushed thefix/phpunit-bridge-expectexceptionmessagematches branch fromab980a9 toc7a2aadCompareApril 9, 2020 17:55
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneApr 10, 2020
@nicolas-grekasnicolas-grekas changed the titlePhpunit 8 deprecates expectExceptionMessageRegExp[PhpUnitBridge] add PolyfillTestCaseTrait::expectExceptionMessageMatches to provide FC with recent phpunit versionsApr 10, 2020
@nicolas-grekas
Copy link
Member

I suppose the codebase should be updated accordingly?

@soyuka
Copy link
ContributorAuthor

you mean change expectExceptionMessageRegExp to expectExceptionMessageMatches?

@dunglas
Copy link
Member

@soyuka yes, in the whole Symfony code base.

nicolas-grekas reacted with thumbs up emoji

…hes to provide FC with recent phpunit versions
@nicolas-grekasnicolas-grekasforce-pushed thefix/phpunit-bridge-expectexceptionmessagematches branch from286518a tocfd5a29CompareApril 15, 2020 15:56
@nicolas-grekas
Copy link
Member

Thank you@soyuka.

@nicolas-grekasnicolas-grekas merged commit14a2046 intosymfony:4.4Apr 15, 2020
@nicolas-grekas
Copy link
Member

@soyuka would you mind contributing a rule to php-cs-fixer so that this is enforced automatically in the future please?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@soyuka@nicolas-grekas@dunglas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp