Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Allowing empty secrets to be set#36400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| thrownew \InvalidArgumentException(sprintf('File is not readable: "%s".',$file)); | ||
| } | ||
| if (null ===$value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you look above at the possible ways to set$value, anull value was only possible when using theaskHidden() interactive prompt. So now, it should not be possible to havenull at this point.
f2c9e66 toc9bf0c8Comparenicolas-grekas commentedApr 10, 2020
Thank you@weaverryan. |
Uh oh!
There was an error while loading.Please reload this page.
Setting secrets to an empty string is a valid value - you can already do this by consuming from an empty file or
stdinwith no input. But it'snot currently possible to use the interactive prompt to set a secret to an empty string. This fixes that.