Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel][WebProfilerBundle] Add session profiling#36364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfrommtarld:feature/session-profiling
Jul 1, 2020

Conversation

@mtarld
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PR

This PR proposes to add session profiling.
It provides stateless checking status and session usage backtraces.

Under are screesnhots of provided profiling:
Screenshot from 2020-04-06 13-42-41
Screenshot from 2020-04-06 13-43-04
Screenshot from 2020-04-06 17-43-17
Screenshot from 2020-04-06 17-43-35

atailouloute, maxhelias, YaFou, rvanlaak, dayofr, alexander-schranz, walva, and chalasr reacted with heart emoji
@mtarldmtarldforce-pushed thefeature/session-profiling branch frome495a82 to64cd933CompareApril 6, 2020 16:31
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 6, 2020
@mtarldmtarldforce-pushed thefeature/session-profiling branch 3 times, most recently from028a19c to4534b47CompareApril 7, 2020 11:29
@fabpot
Copy link
Member

@mtarld Do you have time to take comments into account? I would love to have this PR merged for 5.2. Thank you.

@mtarld
Copy link
ContributorAuthor

Yes of course. I'll try to do it ASAP.

@mtarldmtarldforce-pushed thefeature/session-profiling branch 2 times, most recently from503b6ad toafade8aCompareJune 24, 2020 16:50
@mtarldmtarld requested a review fromstofJune 24, 2020 17:00
@mtarldmtarldforce-pushed thefeature/session-profiling branch 2 times, most recently from78d3d3b tod967255CompareJune 30, 2020 08:20
@mtarldmtarldforce-pushed thefeature/session-profiling branch fromdde4dc1 to66c9777CompareJune 30, 2020 11:39
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Can you also change the implementation ofsrc/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php to simplify the implementation as well? (line 160-163)

@mtarldmtarldforce-pushed thefeature/session-profiling branch from66c9777 to5dbaef8CompareJuly 1, 2020 12:40
@mtarld
Copy link
ContributorAuthor

LGTM. Can you also change the implementation ofsrc/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php to simplify the implementation as well? (line 160-163)

I don't know if I have to change theAbstractSessionListener, in fact as@nicolas-grekas said inthat comment

It's legit to be able to nest a stateless subrequest into a stateful one

And I agree with him. WDYT?

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJul 1, 2020•
edited
Loading

(I confirm that the current check inAbstractSessionListener is correct - it allows tracking "stateless" in subrequests.)

@fabpot
Copy link
Member

Thank you@mtarld.

@fabpotfabpot merged commit8cc90b9 intosymfony:masterJul 1, 2020
@mtarldmtarld deleted the feature/session-profiling branchJuly 1, 2020 14:54
fabpot added a commit that referenced this pull requestSep 18, 2020
…bus)This PR was merged into the 5.2-dev branch.Discussion----------WebProfiler 5.2 is incompatible with HttpKernel 5.1| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AI have upgraded WebProfilerBundle to master in my project. Afterwards, the profiler crashes with the following error.<img width="1049" alt="Bildschirmfoto 2020-09-17 um 21 45 23" src="https://user-images.githubusercontent.com/1506493/93520652-1a67a280-f92f-11ea-8f05-c72cbd996f19.png">Looks like the changes of#36364 require HttpKernel to be bumped to 5.2 as well, so this PR suggests to do just that.Commits-------115d685 WebProfiler 5.2 is incompatible with HttpKernel 5.1
@nicolas-grekasnicolas-grekas modified the milestones:next,5.2Oct 5, 2020
@fabpotfabpot mentioned this pull requestOct 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofAwaiting requested review from stof

+2 more reviewers

@ro0NLro0NLro0NL left review comments

@maxheliasmaxheliasmaxhelias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.2

Development

Successfully merging this pull request may close these issues.

7 participants

@mtarld@fabpot@nicolas-grekas@stof@ro0NL@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp