NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Use default context EXCLUDE_FROM_CACHE_KEY for unsetting OBJECT_TO_POPULATE#36363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

alanpoulain wants to merge1 commit intosymfony:4.4fromalanpoulain:serializer-fix-cache-key-unitialized-properties-default-context

Closed

[Serializer] Use default context EXCLUDE_FROM_CACHE_KEY for unsetting OBJECT_TO_POPULATE#36363

alanpoulain wants to merge1 commit intosymfony:4.4fromalanpoulain:serializer-fix-cache-key-unitialized-properties-default-context

Conversation

Copy link

Contributor

alanpoulain commentedApr 6, 2020

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	N/A
License	MIT
Doc PR	N/A

Following#36332, instead of unsetting directly theOBJECT_TO_POPULATE key from the context ingetCacheKey, we can add the key to theEXCLUDE_FROM_CACHE_KEY array of the default context for Symfony >= 4.4.

alanpoulain requested a review fromdunglas as acode owner

April 6, 2020 15:01

carsonbot added Status: Needs Review Serializer Bug labels

Apr 6, 2020

nicolas-grekas reviewed

Apr 6, 2020

View reviewed changes

src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php OutdatedShow resolvedHide resolved

nicolas-grekas added this to the4.4 milestone

Apr 10, 2020

[Serializer] Use default context EXCLUDE_FROM_CACHE_KEY for unsetting…

8d9a1b6

… OBJECT_TO_POPULATE

nicolas-grekas force-pushed theserializer-fix-cache-key-unitialized-properties-default-context branch fromdd38271 to8d9a1b6Compare

September 2, 2020 15:37

Copy link

Member

nicolas-grekas commentedSep 2, 2020

I think we should reject this PR:

it has a BC breaking potential (merging it for ppl that set theEXCLUDE_FROM_CACHE_KEY key will not unset(OBJECT_TO_POPULATE) anymore).
nobody complained that it could not use the OBJECT_TO_POPULATE as part of the cache key (I fail to see what the use case would be).

Copy link

Member

dunglas commentedSep 2, 2020

I agree with@nicolas-grekas, let's close for now. We can still do it in a new PR if it becomes necessary at some point. Thanks for contributing@alanpoulain!