Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[OptionsResolver] Improve the deprecation feature by handling package and version#36345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

atailouloute
Copy link
Contributor

@atailoulouteatailouloute commentedApr 4, 2020
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?yes
Tickets
LicenseMIT
Doc PRTODO

maxhelias and nicolas-grekas reacted with thumbs up emoji
@atailoulouteatailouloute changed the title[OptionsResolver] Improve the deprecation feature by handling package…[OptionsResolver] Improve the deprecation feature by handling package and versionApr 4, 2020
@atailoulouteatailoulouteforce-pushed theimprove-options-resolver-deprecation branch frome7ecd23 toc7470dfCompareApril 4, 2020 19:48
@nicolas-grekasnicolas-grekas added this to thenext milestoneApr 4, 2020
@atailoulouteatailoulouteforce-pushed theimprove-options-resolver-deprecation branch 3 times, most recently from9597f05 to2d4ff54CompareApril 5, 2020 10:14
@atailoulouteatailoulouteforce-pushed theimprove-options-resolver-deprecation branch 2 times, most recently fromfa043de to23b5749CompareApril 5, 2020 10:34
@atailoulouteatailoulouteforce-pushed theimprove-options-resolver-deprecation branch 4 times, most recently from38d61f7 to56044bbCompareApril 6, 2020 12:15
@atailoulouteatailoulouteforce-pushed theimprove-options-resolver-deprecation branch 2 times, most recently from605e8bb to3da97ecCompareApril 6, 2020 17:40
@atailoulouteatailoulouteforce-pushed theimprove-options-resolver-deprecation branch from3da97ec toc3f5e2cCompareApril 6, 2020 17:49
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(failures are false positives.)

@fabpot
Copy link
Member

Thank you@atailouloute.

@fabpotfabpot merged commitc6a176d intosymfony:masterApr 8, 2020
@atailoulouteatailouloute deleted the improve-options-resolver-deprecation branchApril 8, 2020 07:52
@stof
Copy link
Member

stof commentedApr 8, 2020

Adding the package and version before the message makes it much harder for the ecosystem to support both options-resolver 5.1+ and options-resolver 5.0-, as they would need to detect which signature to use when configuring their options (and I'm not even sure there is an easy and performant way to do that detection, which is important as the OptionsResolver is in the hot path of complex forms IIRC).

@wouterj
Copy link
Member

I think@stof is making a valid point and making the signaturesetDeprecated($message, $package = '', $version = '') makes it much easier to support both versions.

@nicolas-grekas
Copy link
Member

The point is, package and version should not be optional, we really want them to be required.

@xabbuh
Copy link
Member

Keeping$message as the first argument would still help though as PHP would ignore additional arguments for OptionsResolver < 5.1 (we could allow it to benull to opt-in for reusing the default message template).

wouterj reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@KocKocKoc left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

8 participants
@atailouloute@fabpot@stof@wouterj@nicolas-grekas@xabbuh@Koc@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp