Currently, a bug prevents to configure the context keys to exclude from the cache key computation. The value is always replaced in the constructor. This PR fixes the problem.

carsonbot added Status: Needs Review Serializer Bug labels

Apr 4, 2020

dunglas changed the title~~[Serializer] It must possible to configure to keys to exclude for the cache key computation~~[Serializer] It must be possible to configure the keys to exclude from the cache key computation

Apr 4, 2020

dunglas changed the title~~[Serializer] It must be possible to configure the keys to exclude from the cache key computation~~[Serializer] Fix configuration of the cache key

Apr 4, 2020

dunglas force-pushed thefix-exclude-cache-key branch from981b57a to2875404Compare

April 4, 2020 07:46

Copy link

Contributor

alanpoulain commentedApr 4, 2020

It's only an issue if the default context for the cache key is changed by a child class and if the constructor is called afterwards, doesn't it?

nicolas-grekas added this to the4.4 milestone

Apr 4, 2020

nicolas-grekas reviewed

Apr 4, 2020

View reviewed changes

src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php OutdatedShow resolvedHide resolved

Copy link

Member

nicolas-grekas commentedApr 4, 2020

A test case would be nice if you can.

Copy link

MemberAuthor

dunglas commentedApr 5, 2020•
edited
Loading

@alanpoulain it's even the case if you just pass the keys to exclude as parameter of the constructor.
@nicolas-grekas test added and exception message fixed

dunglas force-pushed thefix-exclude-cache-key branch frome7e2aa3 to116110aCompare

April 5, 2020 10:31

dunglas mentioned this pull request

Apr 6, 2020

[Serializer] Use default context EXCLUDE_FROM_CACHE_KEY for unsetting OBJECT_TO_POPULATE#36363

Closed

Copy link

Member

fabpot commentedAug 11, 2020

Is this one still relevant? I see that the original issue has been closed as the problem has been fixed in PHP itself IIUC? /cc@dunglas @nicolas-grekas