Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Add the html5 option to ColorType to validate the input#36302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about astrict_html5 option in aColorValidatorTypeExtension for theColorType that adds it with a normalizer automatically?
stof commentedApr 1, 2020
Constraints should not be implemented in the Form component IMO. |
HeahDude commentedApr 1, 2020
So a solution could be to use the normalizer to add a |
HeahDude commentedApr 1, 2020
But then we should not require the Validator component for such option, add do it in the |
xabbuh commentedApr 2, 2020
I agree, this could simply be part of the |
31b82a2 to0f352fbComparefancyweb commentedApr 8, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I took your ideas into consideration. That's kind of out of my initial use case but it's still going to be useful.
AFAIK, that's already the case. |
fancyweb commentedApr 8, 2020
Should we however add a RegExp constraint (and skip the listener) if the Validator component is there? |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
0f352fb tocaead2dCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
889c936 to56fd5d5CompareUh oh!
There was an error while loading.Please reload this page.
56fd5d5 to454b6ffCompareUh oh!
There was an error while loading.Please reload this page.
fabpot commentedMay 5, 2020
Thank you@fancyweb. |
Continuation of#35626.
I'm resubmitting the initial implementation, this time in the Form component.
This
Colorconstraint is dedicated to the HTML5 input type="color".