Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Allow URL-encoded special characters in basic auth part of URLs#36286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cweiske added a commit to mogic-le/framework that referenced this pull requestMar 31, 2020
Special characters in HTTP Basic Auth passwords in an URL need to be url-encoded.Example: foo@bar becomes foo%40bar, in an URL: http://user:foo%40bar@example.orgThe UrlValidator did not allow percent signs in username and password, and this is changed now.Related bugreport and fix for symfony:-symfony/symfony#36285-symfony/symfony#36286
nicolas-grekas approved these changesMar 31, 2020
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(for 3.4)
xabbuh approved these changesApr 2, 2020
stof approved these changesApr 2, 2020
fabpot approved these changesApr 4, 2020
Member
fabpot commentedApr 4, 2020
Thank you@cweiske. |
fabpot added a commit that referenced this pull requestApr 4, 2020
…auth part of URLs (cweiske)This PR was submitted for the master branch but it was merged into the 3.4 branch instead.Discussion----------[Validator] Allow URL-encoded special characters in basic auth part of URLs| Q | A| ------------- | ---| Branch? | 5.0| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#36285| License | MITSpecial characters in HTTP Basic Auth passwords in an URL need to be url-encoded.Example: `foo@bar` becomes `foo%40bar`, in an URL: `http://user:foo%40bar@example.org`The UrlValidator did not allow percent signs in username and password, and this is changed now.Commits-------8a56c50 Allow URL-encoded special characters in basic auth part of URLs
This was referencedApr 28, 2020
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special characters in HTTP Basic Auth passwords in an URL need to be url-encoded.
Example:
foo@barbecomesfoo%40bar, in an URL:http://user:foo%40bar@example.orgThe UrlValidator did not allow percent signs in username and password, and this is changed now.