FlashBag and AttributeBag are data objects and so should not be available via the service container. The preferred method for accessing these objects is via
$session->getFlashBag() or$session->getAttributeBag()

carsonbot added Status: Needs Review Deprecation labels

Mar 30, 2020

warslett changed the title~~Deprecate flashbag and attributebag services~~[FrameworkBundle] Deprecate flashbag and attributebag services

Mar 30, 2020

warslett force-pushed thedeprecate-flashbag-and-attributebag-services branch from63fef32 to2e4bc95Compare

March 30, 2020 18:55

warslett mentioned this pull request

Mar 30, 2020

[FrameworkBundle] start session on flashbag injection#36063

Merged

nicolas-grekas added this to thenext milestone

Mar 31, 2020

nicolas-grekas reviewed

Mar 31, 2020

View reviewed changes

Copy link

Member

nicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, just minor comments on my side.

UPGRADE-5.1.md OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Resources/config/session.xml OutdatedShow resolvedHide resolved

Tobion reviewed

Mar 31, 2020

View reviewed changes

UPGRADE-6.0.md OutdatedShow resolvedHide resolved

Tobion approved these changes

Mar 31, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 31, 2020

nicolas-grekas approved these changes

Mar 31, 2020

View reviewed changes

warslett force-pushed thedeprecate-flashbag-and-attributebag-services branch fromf35df01 to4baed97Compare

March 31, 2020 20:30

Copy link

ContributorAuthor

warslett commentedMar 31, 2020

rebased to resolve conflicts

Copy link

Member

nicolas-grekas commentedMar 31, 2020•
edited
Loading

Actually, please rebase again to account for#35778, thanks :)

Copy link

ContributorAuthor

warslett commentedMar 31, 2020

@nicolas-grekas rebased and now using new deprecated attributes. Nice feature@atailouloute

fabpot approved these changes

Apr 1, 2020

View reviewed changes

[FrameworkBundle] Deprecate flashbag and attributebag services

f9b52fe

Copy link

Member

fabpot commentedApr 1, 2020

Thank you@warslett.

fabpot force-pushed thedeprecate-flashbag-and-attributebag-services branch from298452a tof9b52feCompare

April 1, 2020 05:18

fabpot mentioned this pull request

Apr 1, 2020

[FrameworkBundle] Deprecate flashbag and attributebag servicessymfony/symfony-docs#13467

Closed

fabpot merged commit09dcbfc intosymfony:master

Apr 1, 2020

warslett deleted the deprecate-flashbag-and-attributebag-services branch

April 1, 2020 05:47

warslett mentioned this pull request

Apr 1, 2020

[HTTP Cache][Session] Something is odd a behaviour was broken from 4.4.4 to 4.4.7#36296

Closed

dannyvw mentioned this pull request

Apr 6, 2020

[NodeBundle] Use flashbag from sessionKunstmaan/KunstmaanBundlesCMS#2661

Merged

nicolas-grekas modified the milestones:next,5.1

May 4, 2020

fabpot mentioned this pull request

May 5, 2020

Release v5.1.0-BETA1#36713

Merged

Copy link

Contributor

BackEndTea commentedJun 1, 2020

I agree that this shouldn't be injected, however i'm running into an issue with this deprecation, namely:

TheSessionInterface does not have thegetFlashBag method that the Session does have. And theSession isnt' available for contsturcot injection, unlike the interface.

Maybe this method should be added to the interface?