ensure that the message is rendered when the line detection fails and we end up with 0 as line number (the implementation also deals with -1 which is sometimes used by Twig for errors when it does not know the line, even though this should not happen for compile-time errors).
fix the detection of the line number when the number is at the end of the sentence, which happens for the deprecation of filters for instance.

carsonbot added Status: Needs Review Bug labels

Mar 30, 2020

yceruto approved these changes

Mar 30, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 30, 2020

nicolas-grekas added this to the4.4 milestone

Mar 30, 2020

stof force-pushed thefix_twig_deprecation_reporting branch from8910be7 to8b1b8afCompare

March 30, 2020 14:53

xabbuh approved these changes

Mar 31, 2020

View reviewed changes

Fix the reporting of deprecations in twig:lint

c329ca7

- ensure that the message is rendered when the line detection fails and  we end up with 0 as line number (the implementation also deals with -1  which is sometimes used by Twig for errors when it does not know the  line, even though this should not happen for compile-time errors).- fix the detection of the line number when the number is at the end of  the sentence, which happens for the deprecation of filters for  instance.

nicolas-grekas force-pushed thefix_twig_deprecation_reporting branch from8b1b8af toc329ca7Compare

March 31, 2020 18:14