Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Fixed calling getters before resolving groups#36245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@HeahDude
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#9939
LicenseMIT
Doc PR~

@HeahDudeHeahDudeforce-pushed thevalidator-fix-getters-in-sequence branch 2 times, most recently from6c68c39 to4c91f52CompareMarch 28, 2020 10:46
@HeahDudeHeahDudeforce-pushed thevalidator-fix-getters-in-sequence branch frome802cf8 toedcfd60CompareMarch 28, 2020 11:31
@nicolas-grekas
Copy link
Member

Thank you@HeahDude.

@nicolas-grekasnicolas-grekas merged commitb9c2693 intosymfony:3.4Mar 31, 2020
@HeahDudeHeahDude deleted the validator-fix-getters-in-sequence branchMarch 31, 2020 18:50
nicolas-grekas added a commit that referenced this pull requestApr 18, 2020
This PR was merged into the 3.4 branch.Discussion----------[Form] Fixed handling groups sequence validation| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |FIx#9939 (comment),Fix#35556| License       | MIT| Doc PR        | ~This is not the same as the original issue fixed by#36245, that was reported in#9939 (comment).The form also fails to cascade sequence validation properly because each nested field is validated against the sequence, and one can fail at a step independently from another which could failed in another step. I've added a lot of tests to ensure this is working properly and tested in a website skeleton too.This PR aims toclose#35556 which tries to fix the same issue but afterwards in its implementation as said in#35556 (comment).Commits-------dfb61c2 [Form] Fixed handling groups sequence validation
This was referencedApr 28, 2020
@bendavies
Copy link
Contributor

bendavies commentedApr 29, 2020•
edited
Loading

this is buggy. it breaks traversal of getters returning collections annotated withValid constraints.
I will PR if someone doesn't first.

jjanvier, tseho, and codegain reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@HeahDude@nicolas-grekas@bendavies@xabbuh@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp