Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel][LoggerDataCollector] Prevent keys collisions in the sanitized logs processing#36239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromfancyweb:http-kernel-logger-data-collector-error-countMar 31, 2020
Merged
[HttpKernel][LoggerDataCollector] Prevent keys collisions in the sanitized logs processing#36239
nicolas-grekas merged 1 commit intosymfony:3.4fromfancyweb:http-kernel-logger-data-collector-error-countMar 31, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…tized logs processing
| [ | ||
| ['message' =>'foo3','context' => ['exception' =>new \ErrorException('warning',0,E_USER_WARNING)],'priority' =>100,'priorityName' =>'DEBUG'], | ||
| ['message' =>'foo3','context' => ['exception' =>newSilencedErrorContext(E_USER_WARNING,__FILE__,__LINE__)],'priority' =>100,'priorityName' =>'DEBUG'], | ||
| ['message' =>'0','context' => ['exception' =>newSilencedErrorContext(E_USER_WARNING,__FILE__,__LINE__)],'priority' =>100,'priorityName' =>'DEBUG'], |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Without the patch, this test leads to an\ErrorException.
nicolas-grekas approved these changesMar 28, 2020
Member
nicolas-grekas commentedMar 31, 2020
Thank you@fancyweb. |
This was referencedApr 28, 2020
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
$sanitizedLogsis used with numeric and "associative" keys. To prevent collisions when the message is a number, we can simply prepend all messages with a random letter (so we avoid a behavior refactor). It doesn't matter since they key is only used for the processing, it is dropped at the end.