NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Adds FormErrorNormalizer#36211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromYaFou:form-error-normalizer

Aug 23, 2020

Merged

[Serializer] Adds FormErrorNormalizer#36211

fabpot merged 1 commit intosymfony:masterfromYaFou:form-error-normalizer

Aug 23, 2020

Conversation

Copy link

Contributor

YaFou commentedMar 25, 2020•
edited
Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix#27428
License	MIT
Doc PR	symfony/symfony-docs#13885

Readme

AddsFormErrorNormalizer for AJAX forms (see the suggestion:#27428). It was on theFOSRestBundle and now it is implemented in theSerializer component.

Roadmap

Core of the class
Output syntax
Support of the children forms
Doc

carsonbot added Status: Needs Review Serializer Feature labels

Mar 25, 2020

nicolas-grekas added this to thenext milestone

Mar 26, 2020

YaFou mentioned this pull request

Mar 27, 2020

[Form] Include Form Error Normalizer#27428

Closed

mohammed-elattar reviewed

Apr 17, 2020

View reviewed changes

src/Symfony/Component/Serializer/Tests/Normalizer/FormErrorNormalizerTest.php OutdatedShow resolvedHide resolved

YaFou marked this pull request as ready for review

June 22, 2020 16:25

YaFou requested a review fromdunglas as acode owner

June 22, 2020 16:25

YaFou mentioned this pull request

Jun 22, 2020

[Serializer] Adds FormErrorNormalizersymfony/symfony-docs#13885

Merged

Copy link

ContributorAuthor

YaFou commentedJun 25, 2020

I don't know why the test suite does not pass. Anybody has an answer?

fabpot requested changes

Aug 17, 2020

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there any "standards"/prior art for form validation? That would be better than having our own if possible.

src/Symfony/Component/Serializer/Normalizer/FormErrorNormalizer.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Serializer/Normalizer/FormErrorNormalizer.phpShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 17, 2020

Copy link

ContributorAuthor

YaFou commentedAug 17, 2020

Is there any "standards"/prior art for form validation? That would be better than having our own if possible.

After some research, I did not find RFCs or something like that. However this type of normalizer can follow the specificationRFC 7807 like theConstraintViolationListNormalizer. In my opinion, we shouldn't follow that because forms can't be used in an API. This normalizer can be used in logs for instance. I need some opinions@fabpot

I will work on reviews next week.

YaFou requested a review fromfabpot

August 23, 2020 15:44

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Aug 23, 2020

fabpot requested changes

Aug 23, 2020

View reviewed changes

src/Symfony/Component/Serializer/Normalizer/FormErrorNormalizer.php OutdatedShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.php OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 23, 2020

YaFou requested a review fromxabbuh as acode owner

August 23, 2020 16:06

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Aug 23, 2020

fabpot requested changes

Aug 23, 2020

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should probably update the FrameworkBundle composer constraint to require Form 5.2+.

src/Symfony/Bundle/FrameworkBundle/Resources/config/form.phpShow resolvedHide resolved

src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php OutdatedShow resolvedHide resolved

src/Symfony/Component/Serializer/CHANGELOG.md OutdatedShow resolvedHide resolved

src/Symfony/Component/Serializer/composer.json OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Aug 23, 2020

YaFou requested a review fromfabpot

August 23, 2020 16:16

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Aug 23, 2020

[Serializer] Adds FormErrorNormalizer

dcb8d8b

Copy link

Member

fabpot commentedAug 23, 2020

Let's wait for the tests... I think they will fail as you haven't not changed deps on FramewokrBundle as I mentioned in my previous review.

Copy link

ContributorAuthor

YaFou commentedAug 23, 2020

Let's wait for the tests... I think they will fail as you haven't not changed deps on FramewokrBundle as I mentioned in my previous review.

@fabpot, the tests passes: the Form Component constraint in the Framework Bundle was already at^5.2.

fabpot approved these changes

Aug 23, 2020

View reviewed changes

Copy link

Member

fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok, symfony/form is already set to 5.2 :)

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 23, 2020

Copy link

Member

fabpot commentedAug 23, 2020

Thank you@YaFou.

fabpot merged commita435dfe intosymfony:master

Aug 23, 2020

YaFou deleted the form-error-normalizer branch

August 23, 2020 16:48

wouterj added a commit to symfony/symfony-docs that referenced this pull request

Oct 3, 2020

feature#13885[Serializer] Adds FormErrorNormalizer (YaFou)

58c9014

This PR was merged into the master branch.Discussion----------[Serializer] Adds FormErrorNormalizer<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `master` for features of unreleased versions).-->This pull request is related tosymfony/symfony#36211.Commits-------9ed468d [Serializer] Adds FormErrorNormalizer

nicolas-grekas modified the milestones:next,5.2

Oct 5, 2020

fabpot mentioned this pull request

Oct 5, 2020

Release v5.2.0-BETA1#38417

Merged