Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] allow cache warmers to add to the list of preloaded classes and files#36209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedMar 25, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?yes
Tickets-
LicenseMIT
Doc PR-

This PR makes cache warmers responsible for returning a list of classes or files to preload. It does so by adding the following toWarmableInterface::warmUp():
@return string[] A list of classes or files to preload on PHP 7.4+

Of course, this return value is properly implemented so that we can see what this provides in practice. Here are the benchmarks on a simple Hello World rendered with Twig:

  • without preloading: 360 req/s
  • with preloading in master: 560 req/s (+55%)
  • with preloading and this PR: 630 req/s (+75%)

azjezz, mleczakm, linaori, COil, magnetik, Cryde, tsantos84, dorumd, alexislefebvre, rvanlaak, and 5 more reacted with hooray emojimleczakm, danieljank, linaori, magnetik, Cryde, OskarStark, tsantos84, sdaoudi, kbond, steltner, and 2 more reacted with heart emojifrankdejonge, mleczakm, realFlowControl, danieljank, linaori, magnetik, Cryde, tsantos84, casimiroarruda, fuzzfree, and 8 more reacted with rocket emoji
@nicolas-grekasnicolas-grekasforce-pushed thebundle-warmup-preload branch 2 times, most recently fromea52a40 tob896527CompareMarch 25, 2020 18:10
stof
stof previously requested changesMar 25, 2020
@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit8a2a69f intosymfony:masterApr 5, 2020
@nicolas-grekasnicolas-grekas deleted the bundle-warmup-preload branchApril 5, 2020 16:59
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@frankdejongefrankdejongefrankdejonge left review comments

@TobionTobionTobion left review comments

@azjezzazjezzazjezz approved these changes

@fabpotfabpotfabpot approved these changes

@stofstofstof left review comments

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

7 participants
@nicolas-grekas@fabpot@stof@frankdejonge@Tobion@azjezz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp