Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Add a \Throwable argument in RetryStrategyInterface methods#36185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add a changelog note tohttps://github.com/symfony/symfony/blob/master/src/Symfony/Component/Messenger/CHANGELOG.md
Why didn't we go with the option of adding the argument to the existing interface, with a proper BC layer? It would make sense to me, don't you think so? |
Replacing the concrete method by a virtual one until 6.0? Our BC promise needs a patch :) |
@chalasr no need: just adding an
@Braxilior up to do it ? |
yes 👍 |
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Retry/MultiplierRetryStrategy.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@chalasr i do think the BC promise needs a patch in general. Seesymfony/symfony-docs#10504 for reference :) |
Thank you@Braxilior. |
This allows to define new retry strategies based on the exceptions thrown during the last handling.