Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Add a \Throwable argument in RetryStrategyInterface methods#36185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromBraxilior:retry-exception
Apr 4, 2020

Conversation

Braxilior
Copy link

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#36182
LicenseMIT

This allows to define new retry strategies based on the exceptions thrown during the last handling.

Copy link
Contributor

@TobionTobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas
Copy link
Member

Why didn't we go with the option of adding the argument to the existing interface, with a proper BC layer? It would make sense to me, don't you think so?

@chalasr
Copy link
Member

Replacing the concrete method by a virtual one until 6.0? Our BC promise needs a patch :)

@nicolas-grekas
Copy link
Member

@chalasr no need: just adding an@param annotation is enough, alongside with:

  • a commented argument on the signature,
  • all implementations updated accordingly (in a similar way for non-final/internal classes)
  • notes in UPGRADE-5.1/6.0.md + CHANGELOG

@Braxilior up to do it ?

chalasr reacted with thumbs up emoji

@Braxilior
Copy link
Author

yes 👍

@ro0NL
Copy link
Contributor

@chalasr i do think the BC promise needs a patch in general. Seesymfony/symfony-docs#10504 for reference :)

@fabpot
Copy link
Member

Thank you@Braxilior.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@TobionTobionTobion approved these changes

@chalasrchalasrchalasr approved these changes

@srozesrozeAwaiting requested review from sroze

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Messenger] Infinite retries depending on exceptions
7 participants
@Braxilior@nicolas-grekas@chalasr@ro0NL@fabpot@Tobion@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp