NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[BrowserKit] fixed missing post request parameters in file uploads#36181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromcodebay:multipart-missing-textplain-parameters

Mar 28, 2020

Merged

[BrowserKit] fixed missing post request parameters in file uploads#36181

fabpot merged 1 commit intosymfony:4.4fromcodebay:multipart-missing-textplain-parameters

Mar 28, 2020

Conversation

Copy link

Contributor

codebay commentedMar 23, 2020

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

Pull Request#35827 "[BrowserKit] Nested file array prevents uploading file" introduced a bug that had not been previously covered by unit tests for the component. Requests that include additional parameters with a file upload are not being included

carsonbot added Status: Needs Review BrowserKit Bug labels

Mar 23, 2020

nicolas-grekas added this to the4.4 milestone

Mar 23, 2020

bobvandevijver reviewed

Mar 27, 2020

View reviewed changes

src/Symfony/Component/BrowserKit/Tests/HttpBrowserTest.php Outdated

		]);
		}

		publicfunctiontestMultiPartRequestWithAdditonalParameters()

Copy link

Contributor

bobvandevijverMar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	publicfunctiontestMultiPartRequestWithAdditonalParameters()
	publicfunctiontestMultiPartRequestWithAdditionalParameters()

fabpot requested changes

Mar 27, 2020

View reviewed changes

src/Symfony/Component/BrowserKit/HttpBrowser.php Outdated


		if ($uploadedFiles =$this->getUploadedFiles($request->getFiles())) {
		$part =newFormDataPart($uploadedFiles);
		$part =newFormDataPart(array_merge($uploadedFiles,$fields));

Copy link

Member

fabpotMar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Here, the order looks wrong. We should probably swap $fields and $uploadedFiles (to be consistent with the previous behavior). Also, can you add a test to avoid any regression in the future.