Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Support customized intl php.ini settings#36149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ddc608e to251aa20Compare...mfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
2c5685d to014259cCompare`IntlDateParser->parse()` behaves differently when `intl.error_level` and/or `intl.use_exceptions` are not 0.This change makes sure `\IntlException` is caught when `intl.use_exceptions` is 1 and warnings thrown when `intl.error_level` is not 0 are ignored.
014259c to61025d1CompareThank you@jorrit. |
No problem@nicolas-grekas, thanks for merging! |
This was referencedMar 27, 2020
Merged
Merged
Merged
fabpot added a commit that referenced this pull requestOct 6, 2024
…LocalizedStringTransformer (bram123)This PR was squashed before being merged into the 5.4 branch.Discussion----------[Form] Support intl.use_exceptions/error_level in NumberToLocalizedStringTransformer| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues || License | MITSame as#36149, support the ini settings `intl.error_level` and `intl.use_exceptions`, by catching the exception and rethrowing as `TransformationFailedException`.Commits-------72549c5 [Form] Support intl.use_exceptions/error_level in NumberToLocalizedStringTransformer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
IntlDateParser->parse()behaves differently whenintl.error_leveland/orintl.use_exceptionsare not 0.This change makes sure
\IntlExceptionis caught whenintl.use_exceptionsis 1 and warnings thrown whenintl.error_levelis not 0 are ignored.