Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Prevent warning in proc_open()#36141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesMar 19, 2020
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please apply fabbot's patch and good to me
chalasr approved these changesMar 19, 2020
ContributorAuthor
BenMorel commentedMar 19, 2020
@nicolas-grekas Done! |
fabpot approved these changesMar 20, 2020
Member
fabpot commentedMar 20, 2020
Thank you@BenMorel. |
ContributorAuthor
BenMorel commentedMar 20, 2020
Thank you. Will this be merged in 4.x and 5.x? |
This was referencedMar 27, 2020
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to returning
false,proc_open()triggers a warning when it fails. For example:When using the
ErrorHandler, the warning gets promoted to an exception, and the next line,if (! is_resource(..., is not executed. This mutes the warning and ensures that the next line is always executed and the proper exception is thrown.