Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpFoundation][HttpKernel][Security] Improve UnexpectedSessionUsageException backtrace#36129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrommtarld:feature/improved-session-exceptionMar 31, 2020
Merged
[HttpFoundation][HttpKernel][Security] Improve UnexpectedSessionUsageException backtrace#36129
nicolas-grekas merged 1 commit intosymfony:masterfrommtarld:feature/improved-session-exceptionMar 31, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
0fd87a5
to8da43fe
Comparenicolas-grekas approved these changesMar 19, 2020
Uh oh!
There was an error while loading.Please reload this page.
8da43fe
to92bf39e
Comparechalasr approved these changesMar 19, 2020
92bf39e
to1e1d332
CompareThank you@mtarld. |
Merged
nicolas-grekas added a commit that referenced this pull requestOct 4, 2024
…s used on stateless routes (nicolas-grekas)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Fix displayed stack trace when session is used on stateless routes| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITIt looks like we forgot to wire this in#36129As a result, the stateless flag is hard to debug.This wiring ensures we can display the offending stack trace instead of a clueless one thrown on kernel.response at the moment.Commits-------90c7093 [FrameworkBundle] Fix passing request_stack to session.listener
fabpot added a commit that referenced this pull requestJan 2, 2025
…tener (nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[Security] Fix triggering session tracking from ContextListener| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Issues | -| License | MITLooks like this was forgotten in#36129The added line in the test case makes the test fail without the patch.Commits-------a00dc82 [Security] Fix triggering session tracking from ContextListener
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
UnexceptedSessionUsageException
backtrace so that it leads to the place in the userland where it was told to use session.