Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AmazonSqsMessenger] Use AsyncAws to handle SQS communication#36094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromjderusse:sqs
May 3, 2020

Conversation

jderusse
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Tickets/
LicenseMIT
Doc PR/

Similar to#35992 this PR use AsyncAws to handle Sqs messages sent/receive

It move complexity of authentication/streaming outside Symfony while keeping HttpClient integration.

tyx, chalasr, Nyholm, Kocal, and thomasbisignani reacted with heart emoji
@Nyholm
Copy link
Member

If I run my application on a lambda or EC2, there is no authentication configuration required in Symfony.

It will automatically pick up the predefined environment variables. Of course I need to configure the application's role in AWS.

@chalasr
Copy link
Member

LGTM 👍 (once rebased)

@chalasr
Copy link
Member

@jderusse Seems like the low-deps job is still failinghttps://travis-ci.org/github/symfony/symfony/jobs/678251415#L5486, any idea?
Needs another rebase also :)

@jderusse
Copy link
MemberAuthor

Rebased. But I think we should wait for AsyncAws version 1.0 before merging.

chalasr reacted with thumbs up emoji

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you. I had some minor suggestions.

👍

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Im happy with the PR now

@fabpot
Copy link
Member

Thank you@jderusse.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@NyholmNyholmNyholm approved these changes

@srozesrozeAwaiting requested review from sroze

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

6 participants
@jderusse@Nyholm@chalasr@fabpot@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp